Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: correct doc about rotate #2959

Merged
merged 1 commit into from
Nov 7, 2021
Merged

docs: correct doc about rotate #2959

merged 1 commit into from
Nov 7, 2021

Conversation

susiwen8
Copy link
Contributor

@susiwen8 susiwen8 commented Nov 4, 2021 •
edited
Loading

PR includes

  • fixed #0
  • add / modify test cases
  • documents, demos

Description

Screen Shot 2021-11-04 at 9 46 59 AM

In the doc, type for rotate is number. However in example code, rotate is boolean. Indeed rotate does support boolean value, casue Math.sin will convert boolean to number. But add boolean for rotate would cause many type definition changes in numbers of reposetories

So I thinks for the time being, we can remove rotate: true in doc, so the user would not be confused.

@visiky visiky merged commit d3c5e85 into antvis:master Nov 7, 2021
@susiwen8 susiwen8 deleted the rotate-text branch November 7, 2021 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visiky visiky visiky approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@susiwen8 @visiky